From b78f394a997c919cff2733d1cf1d2f3b643ad02f Mon Sep 17 00:00:00 2001 From: "Andrew F. Davis" Date: Tue, 11 Jun 2019 10:43:42 -0400 Subject: [PATCH] Makefile: Fix HS builds by removing version reporting dependency The rule for making the HS sysfw.bin file concatenates all its dependencies, the rule for 'sysfw_version' is a phony target and does not produce a file. Drop this dependency for HS. While we are here lets do the same for non-HS builds. Phony targets force the rebuilding of any rule that depends on them, this can cause Make to perform more build steps than are actually needed. Signed-off-by: Andrew F. Davis Tested-by: Denys Dmytriyenko --- Makefile | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/Makefile b/Makefile index c449838..a442e03 100644 --- a/Makefile +++ b/Makefile @@ -141,10 +141,10 @@ $(SYSFW_HS_CERTS_PATH): $(SYSFW_HS_INNER_CERT_PATH) @echo "Signing the SYSFW inner certificate with $(KEY) key..."; ./gen_x509_cert.sh -d -c m3 -b $< -o $@ -l 0x40000 -k $(KEY); -$(soc_objroot)/sysfw.bin: $(SYSFW_HS_CERTS_PATH) $(SYSFW_HS_PATH) sysfw_version +$(soc_objroot)/sysfw.bin: $(SYSFW_HS_CERTS_PATH) $(SYSFW_HS_PATH) cat $^ > $@ else -$(soc_objroot)/sysfw.bin: $(SYSFW_PATH) sysfw_version +$(soc_objroot)/sysfw.bin: $(SYSFW_PATH) @if [ -n "$(KEY)" ]; then \ echo "Signing the SYSFW release image with $(KEY) key..."; \ ./gen_x509_cert.sh -c m3 -b $< -o $@ -l 0x40000 -k $(KEY); \ -- 2.26.2