| author | Piyali Goswami <piyali_g@ti.com> | |
| Sun, 21 Nov 2021 15:09:37 +0000 (20:39 +0530) | ||
| committer | Piyali Goswami <piyali_g@ti.com> | |
| Sun, 21 Nov 2021 15:57:44 +0000 (21:27 +0530) | ||
| commit | 502fb68b163305bc5d5234e8d10bec546a4364b8 | |
| tree | 50dcf5cf240f135f57961d81cae0e00ed0f0359c | tree | snapshot (tar.xz tar.gz zip) |
| parent | a9b567e57b4106f231b3d2773fd5ba3168b0fa19 | commit | diff |
sciclient: sciclient calls to initialize req param and resp param
As part of a strange debug, it was found the SBL was not working with TI
CLANG compiler. The nature of the failure was the DDR was not
initialized. As part of that debug it was found the EMIF PSC was not
getting enabled. Further digging led to the understanding that the PM
module was not getting the right host ID when trying to initialize the
PSC for EMIF in some cases. This was because the Sciclient API was not
initializing the value of the parameter for forwardMsg. In this
particular case the forwardMsg field in the uninitialized reqPrm caused
the Sciclient API to think this is a forwarded message and did not set
the host ID for the PM API. The PM API in turn left the EMIF PSC in a
disabled state leading to the DDR not being initialized.
The fix in this commit is to initialize the SciclientReq and Resp Params
to ensure when there is an additional parameter added to these
structures, they are not uninitialized.
Fixes: PDK-10821
Signed-off-by: Piyali Goswami <piyali_g@ti.com>
As part of a strange debug, it was found the SBL was not working with TI
CLANG compiler. The nature of the failure was the DDR was not
initialized. As part of that debug it was found the EMIF PSC was not
getting enabled. Further digging led to the understanding that the PM
module was not getting the right host ID when trying to initialize the
PSC for EMIF in some cases. This was because the Sciclient API was not
initializing the value of the parameter for forwardMsg. In this
particular case the forwardMsg field in the uninitialized reqPrm caused
the Sciclient API to think this is a forwarded message and did not set
the host ID for the PM API. The PM API in turn left the EMIF PSC in a
disabled state leading to the DDR not being initialized.
The fix in this commit is to initialize the SciclientReq and Resp Params
to ensure when there is an additional parameter added to these
structures, they are not uninitialized.
Fixes: PDK-10821
Signed-off-by: Piyali Goswami <piyali_g@ti.com>