]> Gitweb @ Texas Instruments - Open Source Git Repositories - git.TI.com/gitweb - processor-sdk/pdk.git/commitdiff
[PDK-12082] osal: TaskP: Update TaskP.name type to const char *
authorDon Dominic <a0486429@ti.com>
Thu, 3 Nov 2022 12:58:59 +0000 (18:28 +0530)
committerRishabh Garg <rishabh@ti.com>
Fri, 4 Nov 2022 08:50:07 +0000 (03:50 -0500)
- Update TaskP.name param type from uint8_t * to const char *
- Usage of uint8_t * for name cause MISRA issues
- Both FreeRTOS and SafeRTOS Task Create APIs accepts task name param as const char*
- Hence updating OSAL as well to allign on the same

Signed-off-by: Don Dominic <a0486429@ti.com>
packages/ti/osal/TaskP.h
packages/ti/osal/src/freertos/TaskP_freertos.c
packages/ti/osal/src/qnx/TaskP_qnx.c
packages/ti/osal/src/safertos/TaskP_SafeRTOS.c
packages/ti/osal/test/src/main_osal_test.c
packages/ti/transport/timeSync/example/src/timeSyncExample_main.c
packages/ti/transport/timeSync/example/src/timeSyncExample_switch_main.c

index 27baf1db30df6cb3c9a50ecce7c31e393858edd3..f772ba3d30bf9043d6579509e17032229a7e2fc5 100644 (file)
@@ -103,8 +103,8 @@ typedef void ( * TaskP_Fxn )( void *arg0, void *arg1 );
  */
 typedef struct TaskP_Params_s
 {
-    uint8_t *name;           /*!< Name of the task instance.                  */
-    void *pErrBlk; /*!< Pointer to the error block for task Create */
+    const char *name;    /*!< Name of the task instance.                  */
+    void *pErrBlk;       /*!< Pointer to the error block for task Create */
     int8_t priority;     /*!< The priority of the task                    */
     uint32_t stacksize;  /*!< The stack size of the task                  */
     void *arg0;          /*!< argument 0                                        */
index 5a5e0ead88c81c2fa2f491497b873a7d7954a40f..18d107684a81c4fa7b95ef57dd1503064339173f 100644 (file)
@@ -296,7 +296,7 @@ void TaskP_Params_init(TaskP_Params *params)
 {
     if(params != NULL_PTR)
     {
-        params->name = (uint8_t *)"FREERTOS_TASK";
+        params->name = (const char *)"FREERTOS_TASK";
         params->stacksize = 0;
         params->stack = NULL;
         params->priority = (TaskP_PRIORITY_HIGHEST - TaskP_PRIORITY_LOWEST) / 2;
index f6a3d2b91440951039789f745b44b8ad92e50889..40b7f23a7f3710185c11e4ac6b025625b09891ec 100644 (file)
@@ -89,7 +89,7 @@ TaskP_Status TaskP_delete(TaskP_Handle *handle)
  */
 void TaskP_Params_init(TaskP_Params *params)
 {
-    params->name = (uint8_t *) NULL;
+    params->name = (const char *) NULL;
     params->pErrBlk = (void *) NULL;
     params->priority = 0;
     params->stacksize = 0;
index cbfe21b4b885711366e3283c72865789a6d0e078..bfb7f4134e3af0a69050997f92a2b3a6e503ca15 100644 (file)
@@ -288,7 +288,7 @@ TaskP_Status TaskP_delete( TaskP_Handle *hTaskPtr )
  */
 void TaskP_Params_init( TaskP_Params *params )
 {
-    params->name = ( uint8_t * )"SafeRTOS_TASK";
+    params->name = ( const char * )"SafeRTOS_TASK";
     params->stacksize = 0;
     params->stack = NULL;
     params->priority = ( TaskP_PRIORITY_HIGHEST - TaskP_PRIORITY_LOWEST ) / 2;
index 41fb8f3d8127830697d3de816546dd388d797338..e890e5ee8a2a8eb90b310cbdefa33bb01a03ad6e 100644 (file)
@@ -1707,7 +1707,7 @@ bool OSAL_load_test()
         
         TaskP_Params_init(&taskParams);
         taskParams.priority     = OSAL_LOAD_TEST_TASK_PRIO;   
-        taskParams.name         = (uint8_t *)taskNameStr[i];
+        taskParams.name         = (const char *)taskNameStr[i];
         taskParams.stack        = &gAppTskStackLoadTask[i];
         taskParams.stacksize    = APP_TSK_STACK_MAIN;
         taskParams.arg0         = hTaskSignalSem[i];
index 46f9207119f2a74c81752bb712697a61ba4869fb..3b04fa11582ff4704ee105dd28fc35ae4da0d0dc 100644 (file)
@@ -986,34 +986,34 @@ int main()
     }
     TaskP_Params_init(&taskParams);
     taskParams.priority = 5;
-    taskParams.name = (uint8_t *)"LEDTask";
+    taskParams.name = (const char *)"LEDTask";
     TaskP_create(&timeSync_example_taskLedBlink, &taskParams);
 
     TaskP_Params_init(&taskParams);
     taskParams.priority = 5;
-    taskParams.name = (uint8_t *)"LEDTask";
+    taskParams.name = (const char *)"LEDTask";
     TaskP_create(&timeSync_example_taskLedBlink2, &taskParams);
 
     TaskP_Params_init(&taskParams);
     taskParams.priority = 15;
-    taskParams.name = (uint8_t *) "SwitchTask";
+    taskParams.name = (const char *) "SwitchTask";
     TaskP_create(&timeSync_example_pruIcssTask, &taskParams);
 
     TaskP_Params_init(&taskParams);
     taskParams.priority = 1;
-    taskParams.name = (uint8_t *)"UARTMenuTask";
+    taskParams.name = (const char *)"UARTMenuTask";
     taskParams.arg0 = (void *)emachandle;
     TaskP_create(&timeSync_example_taskUartMenu, &taskParams);
 
     TaskP_Params_init(&taskParams);
     taskParams.priority = 6;
     taskParams.arg0 = (void *)timeSyncHandle;
-    taskParams.name = (uint8_t *)"PTPStatusTask";
+    taskParams.name = (const char *)"PTPStatusTask";
     TaskP_create(&timeSync_example_monitorPTPStatus_Task, &taskParams);
 
     TaskP_Params_init(&taskParams);
     taskParams.priority = 10;
-    taskParams.name = (uint8_t*)"port0_rxTaskFnc";
+    taskParams.name = (const char *)"port0_rxTaskFnc";
     taskParams.stacksize = 0x1000;
     taskParams.arg0 = (void *)emachandle;
 
@@ -1025,7 +1025,7 @@ int main()
     }
     TaskP_Params_init(&taskParams);
     taskParams.priority = 10;
-    taskParams.name = (uint8_t*)"port0_linkTaskFnc";
+    taskParams.name = (const char *)"port0_linkTaskFnc";
     taskParams.stacksize = 0x1000;
     taskParams.arg0 = (void *)emachandle;
     ((ICSS_EmacObject*)emachandle->object)->linkTaskHandle = TaskP_create(&ICSS_EMacOsLinkTaskFnc, &taskParams);
index a7320f3ce5e2552932056d2baab71f8658cecd65..965b356fdd59eed7becf1ec7f0bb0c6230ba96b0 100644 (file)
@@ -996,34 +996,34 @@ int main()
 #endif //EMAC_SWITCH
     TaskP_Params_init(&taskParams);
     taskParams.priority = 5;
-    taskParams.name = (uint8_t *)"LEDTask";
+    taskParams.name = (const char *)"LEDTask";
     TaskP_create(&timeSync_example_taskLedBlink, &taskParams);
 
     TaskP_Params_init(&taskParams);
     taskParams.priority = 5;
-    taskParams.name = (uint8_t *)"LEDTask";
+    taskParams.name = (const char *)"LEDTask";
     TaskP_create(&timeSync_example_taskLedBlink2, &taskParams);
 
     TaskP_Params_init(&taskParams);
     taskParams.priority = 15;
-    taskParams.name = (uint8_t *) "SwitchTask";
+    taskParams.name = (const char *) "SwitchTask";
     TaskP_create(&timeSync_example_pruIcssTask, &taskParams);
 
     TaskP_Params_init(&taskParams);
     taskParams.priority = 1;
-    taskParams.name = (uint8_t *)"UARTMenuTask";
+    taskParams.name = (const char *)"UARTMenuTask";
     taskParams.arg0 = (void *)emachandle;
     TaskP_create(&timeSync_example_taskUartMenu, &taskParams);
 
     TaskP_Params_init(&taskParams);
     taskParams.priority = 6;
     taskParams.arg0 = (void *)timeSyncHandle;
-    taskParams.name = (uint8_t *)"PTPStatusTask";
+    taskParams.name = (const char *)"PTPStatusTask";
     TaskP_create(&timeSync_example_monitorPTPStatus_Task, &taskParams);
 
     TaskP_Params_init(&taskParams);
     taskParams.priority = 10;
-    taskParams.name = (uint8_t*)"port0_rxTaskFnc";
+    taskParams.name = (const char *)"port0_rxTaskFnc";
     taskParams.stacksize = 0x1000;
     taskParams.arg0 = (void *)emachandle;
 
@@ -1035,7 +1035,7 @@ int main()
     }
     TaskP_Params_init(&taskParams);
     taskParams.priority = 10;
-    taskParams.name = (uint8_t*)"port0_linkTaskFnc";
+    taskParams.name = (const char *)"port0_linkTaskFnc";
     taskParams.stacksize = 0x1000;
     taskParams.arg0 = (void *)emachandle;
     ((ICSS_EmacObject*)emachandle->object)->linkTaskHandle = TaskP_create(&ICSS_EMacOsLinkTaskFnc, &taskParams);