From d90e4f48c32db8e1cb469a3fb6a9bdb5eefd6bd7 Mon Sep 17 00:00:00 2001 From: Misael Lopez Cruz Date: Fri, 7 May 2021 13:08:19 -0500 Subject: [PATCH] ETHFW-1776: Fix Coverity analysis issue Fix below static analysis issue reported in Desay-SV's Coverity report: Event cert_str31_c_violation: Underrunning callee's array at -19 by passing argument "size" (which evaluates to 0) in call to "TimeSyncPtp_processPtpFrame". Signed-off-by: Misael Lopez Cruz --- .../v2/protocol/ptp/src/timeSync_ptp.c | 28 +++++++++++-------- 1 file changed, 16 insertions(+), 12 deletions(-) diff --git a/packages/ti/transport/timeSync/v2/protocol/ptp/src/timeSync_ptp.c b/packages/ti/transport/timeSync/v2/protocol/ptp/src/timeSync_ptp.c index d084c499..70612b94 100644 --- a/packages/ti/transport/timeSync/v2/protocol/ptp/src/timeSync_ptp.c +++ b/packages/ti/transport/timeSync/v2/protocol/ptp/src/timeSync_ptp.c @@ -345,6 +345,7 @@ void TimeSyncPtp_processRxNotifyTask(void *arg) uint8_t rxFrame[TIMESYNC_PTP_RX_MAX_MTU]; TimeSyncPtp_Handle hTimeSyncPtp = NULL; volatile bool taskRunFlag = true; + int32_t status; if (arg != NULL) { @@ -355,19 +356,22 @@ void TimeSyncPtp_processRxNotifyTask(void *arg) { SemaphoreP_pend(hTimeSyncPtp->pktRxSemHandle, SemaphoreP_WAIT_FOREVER); - TimeSync_getPtpFrame(hTimeSyncPtp->timeSyncHandle, - &rxFrame[0U], - &size, - &rxPort); - dstMacId = rxFrame; - - if (TIMESYNC_COMPARE_MAC(dstMacId, timeSyncMAC)) - { - TimeSyncPtp_processPtpFrame(hTimeSyncPtp, rxFrame, rxPort, size, 0); - } - else if (TIMESYNC_COMPARE_MAC(dstMacId, linkLocalMAC)) + status = TimeSync_getPtpFrame(hTimeSyncPtp->timeSyncHandle, + &rxFrame[0U], + &size, + &rxPort); + if (status == TIMESYNC_OK) { - TimeSyncPtp_processPtpFrame(hTimeSyncPtp, rxFrame, rxPort, size, 1); + dstMacId = rxFrame; + + if (TIMESYNC_COMPARE_MAC(dstMacId, timeSyncMAC)) + { + TimeSyncPtp_processPtpFrame(hTimeSyncPtp, rxFrame, rxPort, size, 0); + } + else if (TIMESYNC_COMPARE_MAC(dstMacId, linkLocalMAC)) + { + TimeSyncPtp_processPtpFrame(hTimeSyncPtp, rxFrame, rxPort, size, 1); + } } } } -- 2.26.2