From e7ca1f0deded475f89c5fa333cddd9408600c504 Mon Sep 17 00:00:00 2001 From: Frank Livingston Date: Fri, 6 Oct 2017 18:07:38 -0500 Subject: [PATCH] PASDK-417:Remove uninit variable warnings from klocwork report for ARM app --- pasdk/test_arm/doc/klwk_report.txt | 122 +++++++++--------- .../framework/audioStreamDecodeProc.c | 2 + 2 files changed, 64 insertions(+), 60 deletions(-) diff --git a/pasdk/test_arm/doc/klwk_report.txt b/pasdk/test_arm/doc/klwk_report.txt index b18210cb..f9609913 100644 --- a/pasdk/test_arm/doc/klwk_report.txt +++ b/pasdk/test_arm/doc/klwk_report.txt @@ -1,53 +1,61 @@ -October 6, 2017 1:34:19 PM CDT: Running build preparation stage... -October 6, 2017 1:34:20 PM CDT: Build preparation stage completed -October 6, 2017 1:34:20 PM CDT: Running compilation stage... -2> Compiling T:\pasdk\common\aspOutInitSync_common.c -11> Compiling T:\pasdk\test_arm\framework\aspMsg_slave.c -15> Compiling T:\pasdk\test_arm\framework\aspDecOpCircBuf_slave.c -14> Compiling T:\pasdk\common\paf_heapMgr.c -13> Compiling T:\pasdk\common\paf_alg_print.c -12> Compiling T:\pasdk\common\pfp\pfp.c -10> Compiling T:\pasdk\common\components\clk.c -8> Compiling T:\pasdk\common\paf_alg_malloc.c -9> Compiling T:\pasdk\common\paf_alg_create.c -5> Compiling T:\pasdk\common\fwkPort.c -6> Compiling T:\pasdk\common\dbgDib.c -7> Compiling T:\pasdk\common\evmc66x_gpio_dbg.c -4> Compiling T:\pasdk\common\dbgCapAf.c -3> Compiling T:\pasdk\common\audioStreamProc_common.c -1> Compiling T:\pasdk\common\aspDecOpCircBuf_common.c -22> Compiling T:\pasdk\test_arm\framework\itopo\patchs.c -21> Compiling T:\pasdk\test_arm\framework\itopo\params.c -19> Compiling T:\pasdk\test_arm\framework\systemInit.c -18> Compiling T:\pasdk\test_arm\framework\audioStreamDecodeProc_paramsFxns.c -16> Compiling T:\pasdk\test_arm\framework\aspOutInitSync_slave.c -17> Compiling T:\pasdk\test_arm\framework\audioStreamDecodeProc.c -October 6, 2017 1:34:24 PM CDT: Compilation stage completed -October 6, 2017 1:34:24 PM CDT: Running C/C++ defects detection stage... -1> Analyzing aspdecopcircbuf_common.c_0.o -2> Analyzing aspoutinitsync_common.c_1.o -3> Analyzing clk.c_11.o -4> Analyzing dbgcapaf.c_3.o -5> Analyzing dbgdib.c_4.o -6> Analyzing evmc66x_gpio_dbg.c_5.o -7> Analyzing fwkport.c_6.o -8> Analyzing paf_heapmgr.c_10.o -9> Analyzing pfp.c_12.o -10> Analyzing aspdecopcircbuf_slave.c_13.o -11> Analyzing aspmsg_slave.c_14.o -12> Analyzing aspoutinitsync_slave.c_15.o -13> Analyzing paf_alg_malloc.c_8.o -14> Analyzing paf_alg_create.c_7.o -15> Analyzing audiostreamproc_common.c_2.o -16> Analyzing paf_alg_print.c_9.o -17> Analyzing audiostreamdecodeproc_paramsfxns.c_17.o -18> Analyzing params.c_19.o -19> Analyzing patchs.c_20.o -20> Analyzing systeminit.c_18.o -21> Analyzing audiostreamdecodeproc.c_16.o -October 6, 2017 1:37:59 PM CDT: C/C++ defects detection stage completed -October 6, 2017 1:37:59 PM CDT: Running linking stage... -October 6, 2017 1:38:00 PM CDT: Linking stage completed +October 6, 2017 5:52:34 PM CDT: Running build preparation stage... +October 6, 2017 5:52:34 PM CDT: Build preparation stage completed +October 6, 2017 5:52:35 PM CDT: Running compilation stage... +2> Compiling T:\pasdk\test_arm\application\board_utils.c +1> Compiling T:\pasdk\test_arm\Debug_DH\configPkg\package\cfg\app_pa15fg.c +22> Compiling T:\pasdk\test_arm\framework\audioStreamDecodeProc.c +9> Compiling T:\pasdk\common\dbgDib.c +7> Compiling T:\pasdk\common\audioStreamProc_common.c +8> Compiling T:\pasdk\common\dbgCapAf.c +6> Compiling T:\pasdk\common\aspOutInitSync_common.c +4> Compiling T:\pasdk\common\asp0.c +5> Compiling T:\pasdk\common\aspDecOpCircBuf_common.c +3> Compiling T:\pasdk\test_arm\application\main.c +24> Compiling T:\pasdk\test_arm\framework\itopo\params.c +25> Compiling T:\pasdk\test_arm\framework\itopo\patchs.c +23> Compiling T:\pasdk\test_arm\framework\systemInit.c +20> Compiling T:\pasdk\test_arm\framework\audioStreamDecodeProc_paramsFxns.c +10> Compiling T:\pasdk\common\evmc66x_gpio_dbg.c +21> Compiling T:\pasdk\test_arm\framework\aspOutInitSync_slave.c +19> Compiling T:\pasdk\test_arm\framework\aspMsg_slave.c +17> Compiling T:\pasdk\common\pfp\pfp.c +18> Compiling T:\pasdk\test_arm\framework\aspDecOpCircBuf_slave.c +16> Compiling T:\pasdk\common\components\clk.c +15> Compiling T:\pasdk\common\paf_heapMgr.c +14> Compiling T:\pasdk\common\paf_alg_print.c +12> Compiling T:\pasdk\common\paf_alg_malloc.c +13> Compiling T:\pasdk\common\paf_alg_create.c +11> Compiling T:\pasdk\common\fwkPort.c +October 6, 2017 5:52:41 PM CDT: Compilation stage completed +October 6, 2017 5:52:41 PM CDT: Running C/C++ defects detection stage... +1> Analyzing aspoutinitsync_common.c_5.o +2> Analyzing dbgcapaf.c_7.o +3> Analyzing evmc66x_gpio_dbg.c_9.o +4> Analyzing board_utils.c_1.o +5> Analyzing app_pa15fg.c_0.o +6> Analyzing aspoutinitsync_slave.c_19.o +7> Analyzing aspdecopcircbuf_common.c_4.o +8> Analyzing clk.c_15.o +9> Analyzing dbgdib.c_8.o +10> Analyzing fwkport.c_10.o +11> Analyzing paf_heapmgr.c_14.o +12> Analyzing pfp.c_16.o +13> Analyzing aspdecopcircbuf_slave.c_17.o +14> Analyzing aspmsg_slave.c_18.o +15> Analyzing paf_alg_malloc.c_12.o +16> Analyzing main.c_2.o +17> Analyzing paf_alg_create.c_11.o +18> Analyzing asp0.c_3.o +19> Analyzing audiostreamproc_common.c_6.o +20> Analyzing paf_alg_print.c_13.o +21> Analyzing audiostreamdecodeproc_paramsfxns.c_21.o +22> Analyzing params.c_23.o +23> Analyzing patchs.c_24.o +24> Analyzing systeminit.c_22.o +25> Analyzing audiostreamdecodeproc.c_20.o +October 6, 2017 5:55:22 PM CDT: C/C++ defects detection stage completed +October 6, 2017 5:55:22 PM CDT: Running linking stage... +October 6, 2017 5:55:23 PM CDT: Linking stage completed 1 (Local) T:\pasdk\common\pfp\pfp.c:324 NPD.CHECK.MIGHT (1:Critical) Analyze Pointer 'pfpInst.tail' checked for NULL at line 273 may be dereferenced at line 324. @@ -60,17 +68,11 @@ Pointer 'common' checked for NULL at line 128 may be dereferenced at line 107. 4 (Local) T:\pasdk\common\paf_alg_create.c:110 NPD.CHECK.MIGHT (1:Critical) Analyze Pointer 'common' checked for NULL at line 128 may be dereferenced at line 110. -5 (Local) T:\pasdk\test_arm\framework\audioStreamDecodeProc.c:684 UNINIT.STACK.MIGHT (1:Critical) Analyze -'outIsDecInfo1Flag' might be used uninitialized in this function. - -6 (Local) T:\pasdk\test_arm\framework\audioStreamDecodeProc.c:808 UNINIT.STACK.MIGHT (1:Critical) Analyze -'outIsDecDecode1Flag' might be used uninitialized in this function. - -7 (Local) T:\pasdk\common\paf_alg_malloc.c:406 INCONSISTENT.LABEL (4:Review) Analyze +5 (Local) T:\pasdk\common\paf_alg_malloc.c:406 INCONSISTENT.LABEL (4:Review) Analyze Different type of case labels at line 406 and 440 are used in a switch statement -8 (Local) T:\pasdk\common\paf_alg_malloc.c:456 INCONSISTENT.LABEL (4:Review) Analyze +6 (Local) T:\pasdk\common\paf_alg_malloc.c:456 INCONSISTENT.LABEL (4:Review) Analyze Different type of case labels at line 456 and 490 are used in a switch statement -Summary: 8 Local -8 Total Issue(s) +Summary: 6 Local +6 Total Issue(s) diff --git a/pasdk/test_arm/framework/audioStreamDecodeProc.c b/pasdk/test_arm/framework/audioStreamDecodeProc.c index 77d41d79..1b12149a 100644 --- a/pasdk/test_arm/framework/audioStreamDecodeProc.c +++ b/pasdk/test_arm/framework/audioStreamDecodeProc.c @@ -415,6 +415,8 @@ Void taskAsdpFxn( #endif decDone = FALSE; + outIsDecInfo1Flag = 0; + outIsDecDecode1Flag = 0; while (decDone==FALSE) { // wait for received message from master -- 2.39.2