summary | shortlog | log | commit | commitdiff | tree
raw | patch | inline | side by side (parent: 08e9cc4)
raw | patch | inline | side by side (parent: 08e9cc4)
author | Suman Anna <s-anna@ti.com> | |
Thu, 31 May 2018 22:21:43 +0000 (17:21 -0500) | ||
committer | Rafael J. Wysocki <rafael.j.wysocki@intel.com> | |
Wed, 6 Jun 2018 06:34:31 +0000 (08:34 +0200) |
Commit 05829d9431df (cpufreq: ti-cpufreq: kfree opp_data when
failure) has fixed a memory leak in the failure path, however
the patch returned a positive value on get_cpu_device() failure
instead of the previous negative value. Fix this incorrect error
return value properly.
Fixes: 05829d9431df (cpufreq: ti-cpufreq: kfree opp_data when failure)
Cc: 4.14+ <stable@vger.kernel.org> # v4.14+
Signed-off-by: Suman Anna <s-anna@ti.com>
Acked-by: Viresh Kumar <viresh.kumar@linaro.org>
Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
failure) has fixed a memory leak in the failure path, however
the patch returned a positive value on get_cpu_device() failure
instead of the previous negative value. Fix this incorrect error
return value properly.
Fixes: 05829d9431df (cpufreq: ti-cpufreq: kfree opp_data when failure)
Cc: 4.14+ <stable@vger.kernel.org> # v4.14+
Signed-off-by: Suman Anna <s-anna@ti.com>
Acked-by: Viresh Kumar <viresh.kumar@linaro.org>
Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
drivers/cpufreq/ti-cpufreq.c | patch | blob | history |
index 6ba709b6f0950ee3665f718448dbf97710eb039d..896caba5dfe560b3e803c525be4ce335e63c2550 100644 (file)
opp_data->cpu_dev = get_cpu_device(0);
if (!opp_data->cpu_dev) {
pr_err("%s: Failed to get device for CPU0\n", __func__);
- ret = ENODEV;
+ ret = -ENODEV;
goto free_opp_data;
}