remoteproc/k3-r5: initialize TCM memories for ECC

[rpmsg/rpmsg.git] / drivers / remoteproc / ti_k3_r5_remoteproc.c

diff --git a/drivers/remoteproc/ti_k3_r5_remoteproc.c b/drivers/remoteproc/ti_k3_r5_remoteproc.c
index 90bccae7015ba5a0f121e032007241ee9c183b42..3d993ec1f5ea3bb8c90ef5b1a71c22dc632b1a82 100644 (file)
--- a/drivers/remoteproc/ti_k3_r5_remoteproc.c
+++ b/drivers/remoteproc/ti_k3_r5_remoteproc.c
@@ -379,6 +379,17 @@ static int k3_r5_rproc_prepare(struct rproc *rproc)
                dev_err(dev, "unable to enable cores for TCM loading, ret = %d\n",
                        ret);
 
+       /*
+        * Zero out both TCMs unconditionally (access from v8 Arm core is not
+        * affected by ATCM & BTCM enable configuration values) so that ECC
+        * can be effective on all TCM addresses.
+        */
+       dev_dbg(dev, "zeroing out ATCM memory\n");
+       memset(core->mem[0].cpu_addr, 0x00, core->mem[0].size);
+
+       dev_dbg(dev, "zeroing out BTCM memory\n");
+       memset(core->mem[1].cpu_addr, 0x00, core->mem[1].size);
+
        return ret;
 }
 
@@ -567,22 +578,21 @@ static void *k3_r5_rproc_da_to_va(struct rproc *rproc, u64 da, int len,
        if (len <= 0)
                return NULL;
 
-       /* handle R5-view of ATCM addresses first using address 0 */
-       size = core->mem[0].size;
-       if (da >= 0 && ((da + len) <= size)) {
-               offset = da;
-               va = core->mem[0].cpu_addr + offset;
-               return (__force void *)va;
-       }
-
-       /* handle SoC-view addresses for ATCM and BTCM */
+       /* handle both R5 and SoC views of ATCM and BTCM */
        for (i = 0; i < core->num_mems; i++) {
                bus_addr = core->mem[i].bus_addr;
                dev_addr = core->mem[i].dev_addr;
                size = core->mem[i].size;
 
-               if (da >= bus_addr &&
-                   ((da + len) <= (bus_addr + size))) {
+               /* handle R5-view addresses of TCMs */
+               if (da >= dev_addr && ((da + len) <= (dev_addr + size))) {
+                       offset = da - dev_addr;
+                       va = core->mem[i].cpu_addr + offset;
+                       return (__force void *)va;
+               }
+
+               /* handle SoC-view addresses of TCMs */
+               if (da >= bus_addr && ((da + len) <= (bus_addr + size))) {
                        offset = da - bus_addr;
                        va = core->mem[i].cpu_addr + offset;
                        return (__force void *)va;
@@ -958,11 +968,28 @@ static int k3_r5_core_of_get_internal_memories(struct platform_device *pdev,
        for (i = 0; i < num_mems; i++) {
                res = platform_get_resource_byname(pdev, IORESOURCE_MEM,
                                                   mem_names[i]);
-               core->mem[i].cpu_addr = devm_ioremap_resource(dev, res);
-               if (IS_ERR(core->mem[i].cpu_addr)) {
-                       dev_err(dev, "failed to parse and map %s memory\n",
+               if (!res) {
+                       dev_err(dev, "found no memory resource for %s\n",
+                               mem_names[i]);
+                       ret = -EINVAL;
+                       goto fail;
+               }
+               if (!devm_request_mem_region(dev, res->start,
+                                            resource_size(res),
+                                            dev_name(dev))) {
+                       dev_err(dev, "could not request %s region for resource\n",
                                mem_names[i]);
+                       ret = -EBUSY;
+                       goto fail;
+               }
+
+               core->mem[i].cpu_addr = devm_ioremap_wc(dev, res->start,
+                                                       resource_size(res));
+               if (IS_ERR(core->mem[i].cpu_addr)) {
+                       dev_err(dev, "failed to map %s memory\n", mem_names[i]);
                        ret = PTR_ERR(core->mem[i].cpu_addr);
+                       devm_release_mem_region(dev, res->start,
+                                               resource_size(res));
                        goto fail;
                }
                core->mem[i].bus_addr = res->start;
@@ -1047,8 +1074,8 @@ static int k3_r5_core_of_get_sram_memories(struct platform_device *pdev,
                core->sram[i].bus_addr = res.start;
                core->sram[i].dev_addr = res.start;
                core->sram[i].size = resource_size(&res);
-               core->sram[i].cpu_addr = ioremap(res.start,
-                                                resource_size(&res));
+               core->sram[i].cpu_addr = ioremap_wc(res.start,
+                                                   resource_size(&res));
                if (!core->sram[i].cpu_addr) {
                        dev_err(dev, "failed to parse and map sram%d memory at %pad\n",
                                i, &res.start);