| author | Suman Anna <s-anna@ti.com> | |
| Thu, 1 Mar 2018 00:11:56 +0000 (18:11 -0600) | ||
| committer | Suman Anna <s-anna@ti.com> | |
| Mon, 11 Mar 2019 16:57:24 +0000 (11:57 -0500) | ||
| commit | 418ad4b211e9723bc6344167543f98f0fe5944ab | |
| tree | e0b6bd931894a1ec89a4417874a5985c18f9aeaa | tree | snapshot (tar.xz tar.gz zip) |
| parent | 344028330ccef94440b2fc1c771d487c5b413dba | commit | diff |
Revert "remoteproc: Introduce rproc_{start,stop}() functions"
This reverts commit 1efa30d0895e7e9a58a59b0880b330b38245be68.
The commit 1efa30d0895e ("remoteproc: Introduce rproc_{start,stop}()
functions") has refactored code out from rproc_boot() and rproc_shutdown()
to optimize resource allocation overheads during the recovery. This
patch was made with an implicit assumption that the same firmware
image will always be used during recovery (rightfully so in a product
environment), and so the resources will also remain the same. The patch
had also changed the rproc state to RPROC_OFFLINE prior to cleaning up
all resources and disabling the MMU in rproc_shutdown(). This does not
play nice with doing any additional processing steps during recovery
in the resource cleanup function.
This patch is a custom revert of the above commit, accounting for all
the changes added to the rproc_start() and rproc_stop() functions since
kernel v4.13 and some additional changes added in commit 20afed1b45bf
("remoteproc: add infrastructure support to allow pre-loaded remoteprocs")
and commit 2794d1693b05 ("remoteproc: Add support to handle device
specific resource types") thereby allowing a new last trace mechanism
to be supported in a subsequent patch.
Signed-off-by: Suman Anna <s-anna@ti.com>
This reverts commit 1efa30d0895e7e9a58a59b0880b330b38245be68.
The commit 1efa30d0895e ("remoteproc: Introduce rproc_{start,stop}()
functions") has refactored code out from rproc_boot() and rproc_shutdown()
to optimize resource allocation overheads during the recovery. This
patch was made with an implicit assumption that the same firmware
image will always be used during recovery (rightfully so in a product
environment), and so the resources will also remain the same. The patch
had also changed the rproc state to RPROC_OFFLINE prior to cleaning up
all resources and disabling the MMU in rproc_shutdown(). This does not
play nice with doing any additional processing steps during recovery
in the resource cleanup function.
This patch is a custom revert of the above commit, accounting for all
the changes added to the rproc_start() and rproc_stop() functions since
kernel v4.13 and some additional changes added in commit 20afed1b45bf
("remoteproc: add infrastructure support to allow pre-loaded remoteprocs")
and commit 2794d1693b05 ("remoteproc: Add support to handle device
specific resource types") thereby allowing a new last trace mechanism
to be supported in a subsequent patch.
Signed-off-by: Suman Anna <s-anna@ti.com>
| drivers/remoteproc/remoteproc_core.c | diff | blob | history |