| author | Pratyush Yadav <p.yadav@ti.com> | |
| Thu, 18 Feb 2021 12:09:34 +0000 (17:39 +0530) | ||
| committer | Vignesh Raghavendra <vigneshr@ti.com> | |
| Thu, 18 Feb 2021 12:36:25 +0000 (18:06 +0530) | ||
| commit | 93b3daa4a1bb799d1522b7cae81d43727a3e86eb | |
| tree | 9ce7226fac0eceee291f6517b34121cf5e736f53 | tree | snapshot (tar.xz tar.gz zip) |
| parent | b7c53f516e099a7ef76402bfb3c0777b6c321189 | commit | diff |
media: cadence: csi2rx: Fix stream data configuration
Firstly, there is no VC_EN bit present in the STREAM_DATA_CFG register.
Bit 31 is part of the VL_SELECT field. Remove it completely.
Secondly, it makes little sense to enable ith virtual channel for ith
stream. Sure, there might be a use-case that demands it. But there might
also be a use case that demands all streams to use the 0th virtual
channel. Prefer this case over the former because it is less arbitrary
and also makes it very clear what the limitations of the current driver
is instead of giving a false impression that multiple virtual channels
are supported.
Signed-off-by: Pratyush Yadav <p.yadav@ti.com>
Signed-off-by: Vignesh Raghavendra <vigneshr@ti.com>
Firstly, there is no VC_EN bit present in the STREAM_DATA_CFG register.
Bit 31 is part of the VL_SELECT field. Remove it completely.
Secondly, it makes little sense to enable ith virtual channel for ith
stream. Sure, there might be a use-case that demands it. But there might
also be a use case that demands all streams to use the 0th virtual
channel. Prefer this case over the former because it is less arbitrary
and also makes it very clear what the limitations of the current driver
is instead of giving a false impression that multiple virtual channels
are supported.
Signed-off-by: Pratyush Yadav <p.yadav@ti.com>
Signed-off-by: Vignesh Raghavendra <vigneshr@ti.com>
| drivers/media/platform/cadence/cdns-csi2rx.c | diff | blob | history |