| author | Dave Gerlach <d-gerlach@ti.com> | |
| Tue, 20 Sep 2016 15:25:40 +0000 (10:25 -0500) | ||
| committer | Herbert Xu <herbert@gondor.apana.org.au> | |
| Thu, 22 Sep 2016 10:32:53 +0000 (18:32 +0800) | ||
| commit | ad8529fde9e3601180a839867a8ab041109aebb5 | |
| tree | e874b2f92eca57b2d496fdee0779f336edc3993b | tree | snapshot (tar.xz tar.gz zip) |
| parent | 182e283f3e550d70ba5b7e6be66ea74726646166 | commit | diff |
hwrng: omap - Only fail if pm_runtime_get_sync returns < 0
Currently omap-rng checks the return value of pm_runtime_get_sync and
reports failure if anything is returned, however it should be checking
if ret < 0 as pm_runtime_get_sync return 0 on success but also can return
1 if the device was already active which is not a failure case. Only
values < 0 are actual failures.
Fixes: 61dc0a446e5d ("hwrng: omap - Fix assumption that runtime_get_sync will always succeed")
Signed-off-by: Dave Gerlach <d-gerlach@ti.com>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
Currently omap-rng checks the return value of pm_runtime_get_sync and
reports failure if anything is returned, however it should be checking
if ret < 0 as pm_runtime_get_sync return 0 on success but also can return
1 if the device was already active which is not a failure case. Only
values < 0 are actual failures.
Fixes: 61dc0a446e5d ("hwrng: omap - Fix assumption that runtime_get_sync will always succeed")
Signed-off-by: Dave Gerlach <d-gerlach@ti.com>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
| drivers/char/hw_random/omap-rng.c | diff | blob | history |