| author | Florian Fainelli <f.fainelli@gmail.com> | |
| Fri, 5 Oct 2018 03:24:13 +0000 (20:24 -0700) | ||
| committer | David S. Miller <davem@davemloft.net> | |
| Fri, 5 Oct 2018 04:52:49 +0000 (21:52 -0700) | ||
| commit | ca8931948344c485569b04821d1f6bcebccd376b | |
| tree | c24ede5ccead8729da4400bc81a6147fefcfcc77 | tree | snapshot (tar.xz tar.gz zip) |
| parent | 17c357efe5eceebdc3971a48b3d4d61a03c1178b | commit | diff |
net: dsa: b53: Keep CPU port as tagged in all VLANs
Commit c499696e7901 ("net: dsa: b53: Stop using dev->cpu_port
incorrectly") was a bit too trigger happy in removing the CPU port from
the VLAN membership because we rely on DSA to program the CPU port VLAN,
which it does, except it does not bother itself with tagged/untagged and
just usese untagged.
Having the CPU port "follow" the user ports tagged/untagged is not great
and does not allow for properly differentiating, so keep the CPU port
tagged in all VLANs.
Reported-by: Gerhard Wiesinger <lists@wiesinger.com>
Fixes: c499696e7901 ("net: dsa: b53: Stop using dev->cpu_port incorrectly")
Signed-off-by: Florian Fainelli <f.fainelli@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Commit c499696e7901 ("net: dsa: b53: Stop using dev->cpu_port
incorrectly") was a bit too trigger happy in removing the CPU port from
the VLAN membership because we rely on DSA to program the CPU port VLAN,
which it does, except it does not bother itself with tagged/untagged and
just usese untagged.
Having the CPU port "follow" the user ports tagged/untagged is not great
and does not allow for properly differentiating, so keep the CPU port
tagged in all VLANs.
Reported-by: Gerhard Wiesinger <lists@wiesinger.com>
Fixes: c499696e7901 ("net: dsa: b53: Stop using dev->cpu_port incorrectly")
Signed-off-by: Florian Fainelli <f.fainelli@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
| drivers/net/dsa/b53/b53_common.c | diff | blob | history |