summary | shortlog | log | commit | commitdiff | tree
raw | patch | inline | side by side (parent: 689ca28)
raw | patch | inline | side by side (parent: 689ca28)
author | Suman Anna <s-anna@ti.com> | |
Thu, 22 Feb 2018 21:07:43 +0000 (15:07 -0600) | ||
committer | Suman Anna <s-anna@ti.com> | |
Mon, 4 Mar 2019 16:02:36 +0000 (10:02 -0600) |
Add some checks in the mailbox callback function to limit
any processing in the mailbox callback function to only
certain currently valid messages, and drop all the remaining
messages. A debug message is added to print any such invalid
messages when the appropriate trace control is enabled.
Signed-off-by: Subramaniam Chanderashekarapuram <subramaniam.ca@ti.com>
Signed-off-by: Suman Anna <s-anna@ti.com>
any processing in the mailbox callback function to only
certain currently valid messages, and drop all the remaining
messages. A debug message is added to print any such invalid
messages when the appropriate trace control is enabled.
Signed-off-by: Subramaniam Chanderashekarapuram <subramaniam.ca@ti.com>
Signed-off-by: Suman Anna <s-anna@ti.com>
drivers/remoteproc/omap_remoteproc.c | patch | blob | history | |
drivers/remoteproc/omap_remoteproc.h | patch | blob | history |
index 165acb8aeca6d4ed2ab691c6f851bbbd15710b70..fd08d6d51149c0ecef06945a2a94207d25d88240 100644 (file)
dev_info(dev, "received echo reply from %s\n", name);
break;
default:
+ if (msg >= RP_MBOX_READY && msg < RP_MBOX_END_MSG)
+ return;
+ if (msg > oproc->rproc->max_notifyid) {
+ dev_dbg(dev, "dropping unknown message 0x%x", msg);
+ return;
+ }
/* msg contains the index of the triggered vring */
if (rproc_vq_interrupt(oproc->rproc, msg) == IRQ_NONE)
dev_dbg(dev, "no message was found in vqid %d\n", msg);
index 1e6fef753c4f469799f0bd84b042bef9b2c2707a..18f5226176834608e98eb00d5aa8e518120dfde6 100644 (file)
*
* @RP_MBOX_ABORT_REQUEST: a "please crash" request, used for testing the
* recovery mechanism (to some extent).
+ *
+ * Introduce new message definitions if any here.
+ *
+ * @RP_MBOX_END_MSG: Indicates end of known/defined messages from remote core
+ * This should be the last definition.
+ *
*/
enum omap_rp_mbox_messages {
RP_MBOX_READY = 0xFFFFFF00,
RP_MBOX_ECHO_REQUEST = 0xFFFFFF03,
RP_MBOX_ECHO_REPLY = 0xFFFFFF04,
RP_MBOX_ABORT_REQUEST = 0xFFFFFF05,
+ RP_MBOX_END_MSG = 0xFFFFFF06,
};
#endif /* _OMAP_RPMSG_H */