author | Wang Hui <john.wanghui@huawei.com> | |
Fri, 15 Jan 2021 19:59:16 +0000 (22:59 +0300) | ||
committer | Greg Kroah-Hartman <gregkh@linuxfoundation.org> | |
Thu, 21 Jan 2021 17:54:37 +0000 (18:54 +0100) | ||
commit | 927633a6d20af319d986f3e42c3ef9f6d7835008 | |
tree | fb1480a22b0580cb00837eb66e1b63cfd42d2e50 | tree | snapshot (tar.xz tar.gz zip) |
parent | 02039b172327da1e64beca615500367abf8605c6 | commit | diff |
stm class: Fix module init return on allocation failure
In stm_heartbeat_init(): return value gets reset after the first
iteration by stm_source_register_device(), so allocation failures
after that will, after a clean up, return success. Fix that.
Fixes: 119291853038 ("stm class: Add heartbeat stm source device")
Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: Wang Hui <john.wanghui@huawei.com>
Signed-off-by: Alexander Shishkin <alexander.shishkin@linux.intel.com>
Link: https://lore.kernel.org/r/20210115195917.3184-2-alexander.shishkin@linux.intel.com
Cc: stable <stable@vger.kernel.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
In stm_heartbeat_init(): return value gets reset after the first
iteration by stm_source_register_device(), so allocation failures
after that will, after a clean up, return success. Fix that.
Fixes: 119291853038 ("stm class: Add heartbeat stm source device")
Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: Wang Hui <john.wanghui@huawei.com>
Signed-off-by: Alexander Shishkin <alexander.shishkin@linux.intel.com>
Link: https://lore.kernel.org/r/20210115195917.3184-2-alexander.shishkin@linux.intel.com
Cc: stable <stable@vger.kernel.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/hwtracing/stm/heartbeat.c | diff | blob | history |