arm: edma: fix coding style issue related to usage of braces
authorSekhar Nori <nsekhar@ti.com>
Tue, 4 May 2010 08:41:36 +0000 (14:11 +0530)
committerVaibhav Hiremath <hvaibhav@ti.com>
Mon, 23 Jan 2012 19:14:48 +0000 (00:44 +0530)
In the edma driver, there are couple of instances where braces
are used for a single statement 'if' construct.

There are other instances where 'else' part of the if-else construct
does not use braces even if the 'if' part is a multi-line statement.

This patch fixes both.

Signed-off-by: Sekhar Nori <nsekhar@ti.com>
Signed-off-by: Kevin Hilman <khilman@deeprootsystems.com>
Signed-off-by: Hebbar, Gururaja <gururaja.hebbar@ti.com>
arch/arm/common/edma.c

index 6f4119a27c86bf8f849c138f803e8a8fbecc9c5b..fdaa909a2ae448e02cc12102846a5d29e6da6a57 100644 (file)
@@ -283,10 +283,9 @@ setup_dma_interrupt(unsigned lch,
        ctlr = EDMA_CTLR(lch);
        lch = EDMA_CHAN_SLOT(lch);
 
-       if (!callback) {
+       if (!callback)
                edma_shadow0_write_array(ctlr, SH_IECR, lch >> 5,
                                (1 << (lch & 0x1f)));
-       }
 
        edma_cc[ctlr]->intr_data[lch].callback = callback;
        edma_cc[ctlr]->intr_data[lch].data = data;
@@ -346,12 +345,11 @@ static irqreturn_t dma_irq_handler(int irq, void *data)
                                /* Clear the corresponding IPR bits */
                                edma_shadow0_write_array(ctlr, SH_ICR, j,
                                                        (1 << i));
-                               if (edma_cc[ctlr]->intr_data[k].callback) {
+                               if (edma_cc[ctlr]->intr_data[k].callback)
                                        edma_cc[ctlr]->intr_data[k].callback(
                                                k, DMA_COMPLETE,
                                                edma_cc[ctlr]->intr_data[k].
                                                data);
-                               }
                        }
                }
                cnt++;
@@ -443,9 +441,8 @@ static irqreturn_t dma_ccerr_handler(int irq, void *data)
                if ((edma_read_array(ctlr, EDMA_EMR, 0) == 0)
                    && (edma_read_array(ctlr, EDMA_EMR, 1) == 0)
                    && (edma_read(ctlr, EDMA_QEMR) == 0)
-                   && (edma_read(ctlr, EDMA_CCERR) == 0)) {
+                   && (edma_read(ctlr, EDMA_CCERR) == 0))
                        break;
-               }
                cnt++;
                if (cnt > 10)
                        break;
@@ -483,8 +480,9 @@ static int reserve_contiguous_slots(int ctlr, unsigned int id,
                        if (id == EDMA_CONT_PARAMS_FIXED_EXACT) {
                                stop_slot = i;
                                break;
-                       } else
+                       } else {
                                count = num_slots;
+                       }
                }
        }
 
@@ -1366,8 +1364,9 @@ static int __init edma_probe(struct platform_device *pdev)
                                break;
                        else
                                return -ENODEV;
-               } else
+               } else {
                        found = 1;
+               }
 
                len[j] = resource_size(r[j]);