summary | shortlog | log | commit | commitdiff | tree
raw | patch | inline | side by side (parent: 7596175)
raw | patch | inline | side by side (parent: 7596175)
author | Ursula Braun <ubraun@linux.ibm.com> | |
Wed, 30 Jan 2019 17:51:00 +0000 (18:51 +0100) | ||
committer | David S. Miller <davem@davemloft.net> | |
Fri, 1 Feb 2019 22:45:44 +0000 (14:45 -0800) |
Comparing an int to a size, which is unsigned, causes the int to become
unsigned, giving the wrong result. kernel_sendmsg can return a negative
error code.
Signed-off-by: Ursula Braun <ubraun@linux.ibm.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
unsigned, giving the wrong result. kernel_sendmsg can return a negative
error code.
Signed-off-by: Ursula Braun <ubraun@linux.ibm.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
net/smc/smc_clc.c | patch | blob | history |
diff --git a/net/smc/smc_clc.c b/net/smc/smc_clc.c
index 776e9dfc915dd5fb9200a5440862b7bbbc4f5440..d53fd588d1f5a4450819934c83cf960dc29ff46b 100644 (file)
--- a/net/smc/smc_clc.c
+++ b/net/smc/smc_clc.c
vec.iov_len = sizeof(struct smc_clc_msg_decline);
len = kernel_sendmsg(smc->clcsock, &msg, &vec, 1,
sizeof(struct smc_clc_msg_decline));
- if (len < sizeof(struct smc_clc_msg_decline))
+ if (len < 0 || len < sizeof(struct smc_clc_msg_decline))
len = -EPROTO;
return len > 0 ? 0 : len;
}