| author | Miklos Szeredi <mszeredi@redhat.com> | |
| Mon, 21 Mar 2016 16:31:44 +0000 (17:31 +0100) | ||
| committer | Miklos Szeredi <miklos@szeredi.hu> | |
| Mon, 21 Mar 2016 16:31:44 +0000 (17:31 +0100) | ||
| commit | 11f3710417d026ea2f4fcf362d866342c5274185 | |
| tree | 9f0904f868dd155bf00b0b10caf264d2a4065355 | tree | snapshot (tar.xz tar.gz zip) |
| parent | 3c2de27d793bf55167804fc47954711e94f27be7 | commit | diff |
ovl: verify upper dentry before unlink and rename
Unlink and rename in overlayfs checked the upper dentry for staleness by
verifying upper->d_parent against upperdir. However the dentry can go
stale also by being unhashed, for example.
Expand the verification to actually look up the name again (under parent
lock) and check if it matches the upper dentry. This matches what the VFS
does before passing the dentry to filesytem's unlink/rename methods, which
excludes any inconsistency caused by overlayfs.
Signed-off-by: Miklos Szeredi <mszeredi@redhat.com>
Unlink and rename in overlayfs checked the upper dentry for staleness by
verifying upper->d_parent against upperdir. However the dentry can go
stale also by being unhashed, for example.
Expand the verification to actually look up the name again (under parent
lock) and check if it matches the upper dentry. This matches what the VFS
does before passing the dentry to filesytem's unlink/rename methods, which
excludes any inconsistency caused by overlayfs.
Signed-off-by: Miklos Szeredi <mszeredi@redhat.com>
| fs/overlayfs/dir.c | diff | blob | history |