]> Gitweb @ Texas Instruments - Open Source Git Repositories - git.TI.com/gitweb - ti-linux-kernel/ti-linux-kernel.git/commitdiff
staging: comedi: ni_mio_common: fix wrong insn_write handler
authorIan Abbott <abbotti@mev.co.uk>
Wed, 7 Sep 2016 14:33:12 +0000 (15:33 +0100)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Sun, 11 Sep 2016 07:59:58 +0000 (09:59 +0200)
commit 5ca05345c56cb979e1a25ab6146437002f95cac8 upstream.

For counter subdevices, the `s->insn_write` handler is being set to the
wrong function, `ni_tio_insn_read()`.  It should be
`ni_tio_insn_write()`.

Signed-off-by: Ian Abbott <abbotti@mev.co.uk>
Reported-by: Éric Piel <piel@delmic.com>
Fixes: 10f74377eec3 ("staging: comedi: ni_tio: make ni_tio_winsn() a proper comedi (*insn_write)")
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/staging/comedi/drivers/ni_mio_common.c

index 457b88481db0a9b4c6fde73fceef556dc66b8278..3312ae622284071e037edb3cf3e4f4dd0bd2c35f 100644 (file)
@@ -4404,7 +4404,7 @@ static int ni_E_init(struct comedi_device *dev)
                else
                        s->maxdata = 0xffffff;
                s->insn_read = ni_tio_insn_read;
-               s->insn_write = ni_tio_insn_read;
+               s->insn_write = ni_tio_insn_write;
                s->insn_config = ni_tio_insn_config;
 #ifdef PCIDMA
                s->subdev_flags |= SDF_CMD_READ /* | SDF_CMD_WRITE */;