]> Gitweb @ Texas Instruments - Open Source Git Repositories - git.TI.com/gitweb - ti-u-boot/ti-u-boot.git/commitdiff
video: SIMPLE_PANEL depends on DM_GPIO
authorAsherah Connor <ashe@kivikakk.ee>
Wed, 3 Mar 2021 03:46:47 +0000 (14:46 +1100)
committerAnatolij Gustschin <agust@denx.de>
Sat, 10 Apr 2021 14:50:07 +0000 (16:50 +0200)
SIMPLE_PANEL currently only depends on PANEL && BACKLIGHT, but the code
makes references to dm_gpio_set_value and gpio_request_by_name.  These
are defined in drivers/gpio/gpio-uclass.c, so a dependency on DM_GPIO
corrects these link errors:

aarch64-linux-gnu-ld.bfd: drivers/built-in.o: in function `simple_panel_set_backlight':
/home/kameliya/u-boot/drivers/video/simple_panel.c:42: undefined reference to `dm_gpio_set_value'
aarch64-linux-gnu-ld.bfd: drivers/built-in.o: in function `simple_panel_enable_backlight':
/home/kameliya/u-boot/drivers/video/simple_panel.c:27: undefined reference to `dm_gpio_set_value'
aarch64-linux-gnu-ld.bfd: drivers/built-in.o: in function `simple_panel_of_to_plat':
/home/kameliya/u-boot/drivers/video/simple_panel.c:72: undefined reference to `gpio_request_by_name'

This issue is only exposed if you have a board which enables
CONFIG_DM_VIDEO without CONFIG_DM_GPIO; so far, none do, but soon a QEMU
board may.

Signed-off-by: Asherah Connor <ashe@kivikakk.ee>
drivers/video/Kconfig

index 63ae2ba43c490f79214bc474871bd24002245702..b69ffcae4b2a1029ad9f68e289ec3fd87e412d17 100644 (file)
@@ -209,7 +209,7 @@ config PANEL
 
 config SIMPLE_PANEL
        bool "Enable simple panel support"
-       depends on PANEL && BACKLIGHT
+       depends on PANEL && BACKLIGHT && DM_GPIO
        default y
        help
          This turns on a simple panel driver that enables a compatible