mac80211: warn on enabling beacon while off channel

This can cause the beaconing to start on the wrong channel.
Several such races were fixed but still add a WARN_ON as
we'd like to know if something like that still happens.

Signed-off-by: Eyal Shapira <eyal@wizery.com>

diff --git a/net/mac80211/main.c b/net/mac80211/main.c
index 42481bd130557ee505e3399d5ae34fe5d365f60d..8778046734b6f1e1cd1ea5983fada357f15e7db9 100644 (file)
--- a/net/mac80211/main.c
+++ b/net/mac80211/main.c
@@ -263,6 +263,10 @@ void ieee80211_bss_info_change_notify(struct ieee80211_sub_if_data *sdata,
                                WARN_ON(1);
                                break;
                        }
+
+                       /* beacon shouldn't be enabled while off channel */
+                       WARN_ON(sdata->vif.bss_conf.enable_beacon
+                               && local->tmp_channel);
                }
        }